Conversation
yurii-litvinov
suggested changes
Dec 20, 2022
| #include "lexerOfComments.h" | ||
|
|
||
| int changeStage(int statusTable[5][2], int stage, int symbol) { | ||
| int posSymbol = symbol % 42 == 0 ? 0 : 1; |
There was a problem hiding this comment.
Отступы табуляциями вроде стайлгайдом запрещены
| #include "lexerOfComments.h" | ||
|
|
||
| int changeStage(int statusTable[5][2], int stage, int symbol) { | ||
| int posSymbol = symbol % 42 == 0 ? 0 : 1; |
There was a problem hiding this comment.
А вообще, интересно, автомат умеет различать только два типа символов, тогда как по смыслу есть *, / и всё остальное, три категории
| while (fscanf(file, "%c", &symbol) == 1) { | ||
| if (symbol == '/') { | ||
| switch (stage) { | ||
| case(1): |
| indexBuffer = 0; | ||
| break; | ||
| } | ||
| stage = changeStage(statusTable, stage, (int)symbol); |
There was a problem hiding this comment.
Это должно произойти в любом случае, поэтому должно быть вне if-а (вообще, if должен отвечать только за побочные эффекты автомата, изменением состояния он управлять не имеет права)
| ++indexBuffer; | ||
| } else { | ||
| clearBuffer(bufferWithOneComment, &indexBuffer); | ||
| stage = 1; |
| typedef enum Error { | ||
| ok, | ||
| fileProblem | ||
| }Error; |
There was a problem hiding this comment.
Suggested change
| }Error; | |
| } Error; |
Comment on lines
1
to
2
| #pragma once | ||
| #include <stdio.h> |
There was a problem hiding this comment.
Suggested change
| #pragma once | |
| #include <stdio.h> | |
| #pragma once | |
| #include <stdio.h> |
| fileProblem | ||
| }Error; | ||
|
|
||
| char* lexerOfComments(const char* fileNameTable, const char* fileNameWithStrings, Error* errorCheck); No newline at end of file |
| #include <stdio.h> | ||
| #include <stdlib.h> | ||
| #include "test.h" | ||
|
|
| #pragma once | ||
| #include <stdbool.h> | ||
|
|
||
| bool test(); No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.